Inconsistent declaration of maliput_* build_depend dependencies
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
`maliput_malidrive` is declared as a "build_depend" dependency whereas no other "maliput_*" is:
https://github.com/ToyotaResearchInstitute/delphyne/blob/473772c8e3ac2dafc602f8de4d65b0e005a46b07/package.xml#L10-L21
We should rectify this inconsistency, perhaps by switching to "depend":
https://www.ros.org/reps/rep-0140.html#depend-multiple
See this Slack thread: https://tri-internal.slack.com/archives/C028K32S4FP/p1631534906053100?thread_ts=1631505299.052000&cid=C028K32S4FP
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading package.xml lines 10-21 and REP-0140's depend-multiple guidance, then compare the maliput_* declarations. Done means the dependency declarations are consistent with the selected ROS dependency type; the linked Slack discussion may clarify whether depend is correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100