maliput / maliput/delphyne

Replace usage of Isometry3<T> by RigidTransform<T> to simplify code

Open
#702 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement
Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Isometry has been deprecated in favor of RigidTransform because of familiar semantics with roboticists and enhanced checks in rotation matrices for robotic use cases.

After https://github.com/ToyotaResearchInstitute/drake-vendor/pull/14, and as part of https://github.com/ToyotaResearchInstitute/delphyne/pull/701/files code is a bit verbose because of keeping the Isometry3 in the interface. We should replace the Isometry3 by RigidTransform in places where it is consumed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced drake-vendor PR #14 and delphyne PR #701 to understand the RigidTransform interface change. Locate the delphyne consumers that still expose or use Isometry3; the work is done when the relevant interfaces and their consumers use RigidTransform instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
autonomous-driving
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.