makeplane / makeplane/plane

Comment Reaction Activity Crashes Celery Task When Reaction Not Found

Open
#9,175 2 comments 0 reactions 2 assignees View on GitHub

@vihar is already working on this.

Since May 30, 2026.

🐛bug plane
Dominant language
TypeScript
Stars
59.6k
Forks
5.8k
Avg merge
1d 22h
Merged PRs (30d)
49

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current behavior

When a comment reaction activity event is processed and the reaction no longer exists in the database (e.g. due to a race condition), the Celery task crashes with a TypeError and I see the error message attached below:

TypeError: cannot unpack non-iterable NoneType object

What I expect is that the activity task handles missing reactions gracefully and continues processing other activities.

File: apps/api/plane/bgtasks/issue_activities_task.py, lines 1152–1160 — .values_list(...).first() returns None when no reaction is found, and unpacking None into two variables raises TypeError

Steps to reproduce
  1. Add a reaction to a comment
    1. Remove the reaction before the Celery task processes the event (race condition)
    1. Observe the entire issue_activity task fails silently — no activity logged for that event
Environment

Production

Browser

Google Chrome

Variant

Cloud

Version

v0.17.0-dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.