Possible .dockerignore misconfiguration
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 59.6k
- Forks
- 5.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 49
Description
Hello, and thank you for your work on this repository!
As part of my research, I am analyzing how developers configure .dockerignore in popular repositories.
During my analysis, I noticed that /.dockerignore might have been written under the assumption that .dockerignore and .gitignore follow the same pattern semantics, while they actually differ.[^1] In particular, the following pattern drew my attention:
https://github.com/makeplane/plane/blob/1d443310ce7a9fb1f42213397df4dc008dd66b48/.dockerignore#L2
According to Docker's specification, this pattern matches *.pyc only in the top-level directory. (To ignore *.pyc in any directory, the .dockerignore file needs to list **/*.pyc)
Was this pattern written intentionally? If not, I'd be happy to submit a pull request to adjust it.
And if possible, could you tell me whether you were aware of the difference between .dockerignore and .gitignore? (I would like to know whether the differences are generally well recognized, or if they tend to slip developers' minds.)
Thank you again for maintaining this repository!
[^1]: See .gitignore doc, .dockerignore doc, and a blog post about the differences
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading line 2 of /.dockerignore and compare its pattern semantics with Docker's documented rules and the linked Git ignore behavior. Verify whether the pattern matches .pyc files only at the top level; done means confirming the intent and, if it is unintended, adjusting the pattern so the intended files are ignored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100