makeplane / makeplane/plane

[feature]: remove minio direct endpoint

Open
#5,608 1 comment 2 reactions 2 assignees View on GitHub

@vihar is already working on this.

Since Sep 13, 2024.

✨feature
Dominant language
TypeScript
Stars
59.6k
Forks
5.8k
Avg merge
1d 22h
Merged PRs (30d)
49

Description

Is there an existing issue for this?
  • I have searched the existing issues
Summary

I have an S3 bucket and I'd like to use that instead of minio.

However I cannot remove minio from the docker compose because its local hostname is directly referenced by the proxy.
I don't know exactly why you need to have an endpoint handled by the proxy and pointing directly to the minio api but having will force anyone to run minio-server even if they use s3.

Any functionality that relies on this direct connection could instead pass through the backend (with the minio client installed) so that it can communicate with either minio or s3 transparently. Basically decoupling the project from minio

Honestly I don't exactly understand why there is the need of a proxy at all while maybe docker local networks could be used but this is another point entirely.

At the moment the only sollution is to pass a custom confiuration to the proxy, but this is error prone since I now need to check if the proxy configuration has changed at each version change

--edit

not even passing a custom config to the proxy works

Why should this be worked on?

This would allow to run one less service to host plane

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.