makeplane / makeplane/plane

[bug]: Unable to leave a full comment in Japanese due to return key for IME confirmation prematurely triggers submission

Open
#5,485 1 comment 0 reactions 2 assignees View on GitHub

@vihar is already working on this.

Since Sep 2, 2024.

🐛bug
Dominant language
TypeScript
Stars
59.6k
Forks
5.8k
Avg merge
1d 22h
Merged PRs (30d)
49

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current behavior

While leaving comments on an issue, writing in English is fine but when I use a Japanese Input Method (macOS default), after typing in each word the last key stroke (which is always return) triggers the "submit" button. As a result, any attempt at inputing Japanese text of any length gets interrupted after the first word.

In this screenshot, I typed in a single word and is one step away from confirmation. As soon as I press return to finalize the word (and expect to start typing in the next word), the comment gets submitted.

image

Steps to reproduce
  1. Go to an issue.
  2. Click "Add comment..."
  3. Switch to the system Japanese input method on macOS (not sure if Windows does the same)
  4. Type in "a" so the IME shows up with a suggestion "あ"
  5. Press return to confirm the "あ"
Environment

Production

Browser

Google Chrome

Variant

Cloud

Version

v0.22-dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.