[feature]: Allow using private IPs for webhooks
Open
@vihar is already working on this.
Since Jul 26, 2024.
✨feature
- Dominant language
- TypeScript
- Stars
- 59.6k
- Forks
- 5.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 49
Description
Is there an existing issue for this?
- I have searched the existing issues
Summary
Looks like Plane is now prohibiting the creation of webhooks with private IP addresses:
https://github.com/makeplane/plane/blob/2c609670c83a82301f41f7a69eca8bac1c8aec37/apiserver/plane/app/serializers/webhook.py#L43-L46
Why should this be worked on?
While blocking private addresses for public installations seems reasonable, it prevents services in environments like VPN or Kubernetes cluster from being used as webhook endpoints.
Maybe we should add a configuration option to allow private addresses?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.