makeplane / makeplane/plane

[bug]: Update to Docker command breaks production installs

Open
#4,646 1 comment 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

🐛bug
Dominant language
TypeScript
Stars
59.6k
Forks
5.8k
Avg merge
1d 22h
Merged PRs (30d)
49

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current behavior

Recently the stable docker images changed their command structure. For instance, command: /usr/local/bin/start.sh web/server.js web was changed to command: node web/server.js web in the compose files.

This is a breaking change for any user hosting via docker. command shouldn't be an option used in compose unless you are trying to alter the intended function. stable images should use CMD in the Dockerfile, and command should be removed from the compose files to ensure future iterations of images use the appropriate startup.

If the plane-backend wishes to be reused for low-size, a base plane-backend image should be built, and a plane-api image should be built FROM plane-backend to allow for separate CMD use.

Steps to reproduce
  1. Docker pull the latest stable from an install prior to this commit: https://github.com/makeplane/plane/commit/1c377163d2b184fae5806ee33ef0325d79e51ade
  2. Restart
  3. Watch production go down
Environment

Production

Browser

None

Variant

Self-hosted

Version

stable

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.