makeplane / makeplane/plane

[bug]: 'Sign in with GitHub' uses primary email address as if it were a primary key and not something that can be changed

Open
#3,183 1 comment 0 reactions 2 assignees View on GitHub

@pablohashescobar is already working on this.

Since Dec 27, 2023.

🌟enhancement
Dominant language
TypeScript
Stars
59.6k
Forks
5.8k
Avg merge
1d 22h
Merged PRs (30d)
49

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current behavior

Recently I changed my primary email address on GitHub and today found that I could no longer log into my Plane workspace -- signing in with GitHub presented me the "Create your first workspace" flow and any attempt to navigate to my workspace via URL showed that I was not authorized.

I quickly realized the issue, and have confirmed that switching my primary email back on GitHub fixed this, but this should not occur. When a user logs in with any third-party service, where the email address is not the primary identifier for the user, you cannot use the email as if it were a primary key. This completely blocks users from changing email addresses, as shown in this case.

Steps to reproduce
  1. Sign into Plane with GitHub, create workspace
  2. Add a new email on GitHub and set it as the primary address for the account
  3. Log out of Plane
  4. Try to log in using GitHub
  5. Notice you'll be prompted to create a new workspace
Browser

N/A

Version

Cloud

Edit: I can't even change my email address on Plane so I'm stuck using an older email address as my primary on GitHub.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.