makeomatic / makeomatic/redux-connect
add react-router middleware
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 545
- Forks
- 61
- PR merge metrics
- No merged PRs in 30d
Description
The `README.md` gives an example of how you can use this with `applyRouterMiddleware`. Would it make more sense to provide your own middleware instead? Might look something like:
``` javascript
const useReduxAsyncConnect = (helpers, filters) => ({
renderRouterContext: (child, props) => (
{child}
)
})
```
and would be used like
``` javascript
const component = (
applyRouterMiddleware(useReduxConnect(helpers, filters), useScroll())}
history={history}
routes={getRoutes(store)}
/>
);
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the README.md example using applyRouterMiddleware and inspect how the package currently integrates with react-router. Compare that usage with the proposed useReduxAsyncConnect middleware shape and determine the expected behavior for helpers, filters, and renderRouterContext. Done means the middleware is provided and the README example reflects its use.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100