makeomatic / makeomatic/redux-connect

filter-ed promises not being executed in componentDidMount

Open
#30 6 comments 0 reactions 0 assignees View on GitHub
bug enhancement help wanted
Dominant language
JavaScript
Stars
545
Forks
61
PR merge metrics
No merged PRs in 30d

Description

`BEGIN_GLOBAL_LOAD`/`END_GLOBAL_LOAD` are dispatched on the client side even when `filter` stops the `asyncConnect` from blocking the render function. However, once the component is mounted, since the redux has saved the state `loaded` as `true`, it does not fetch the data. Due to this you have to manually redo the logic for re-fetching data in these instances. It would be nice to have some logic to ascertain that the promise is executed in `componentDidMount`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Trace asyncConnect from the filter handling through the client-side BEGIN_GLOBAL_LOAD and END_GLOBAL_LOAD dispatches, then inspect the componentDidMount path and the saved loaded state. Done means filtered promises execute after mounting without requiring manual refetch logic, while the loading behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.