makecindy / makecindy/cindy

PR #4496 需要维护者确认:Pi harness 规则文档补记 runtime 退役不变量

Open
#4,503 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

PR https://github.com/makecindy/cindy/pull/4496 改动了审查规则文档 `docs/dev-rules/pi-harness.md`。

## 这次改了什么

修复本地已有 Pi 任务跨来源切换被 `#3601` 缩窗守卫 fail-closed 拒绝的问题(issue #4486):预期内的 runtime 退役走受支持路径,未预期关闭仍抛原 `PRECONDITION_FAILED`。

规则文档在 §2 新增行为不变量:

- 本地 Pi 跨 proxy 供应商身份切换来源(`x-cindy-pi-provider-id` 会变化)或 Orca worker 路由重建会退役旧 runtime(`runtimeRetired`),目标 route 交给下一次发送懒创建。
- 需要缩窗保护时,90% 固定压力线事务必须在退役关闭前完成。
- 不允许保留旧进程只改 provider store。

## 为何需要确认

`pi-harness.md` 是审查判据本身。这次不是机械校对或已有结论的同义改写,而是把「来源切换必须退役 runtime + 缩窗保护必须先于关闭」写进规则。维护者需要确认这条不变量是否与现有 Pi 窗口保护、远端 fail-closed、以及 #3601 / #3705 的既有裁决一致。

## 请维护者怎么做

请直接在 PR 上 Approve;如果规则表述或实现顺序需要改,请 Request Changes。不要只摘标签或只在讨论里口头同意。

---
关联 PR:#4496(作者 @zyjisdog);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的审查规则文档变更,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Read docs/dev-rules/pi-harness.md §2 and review PR #4496 first. Then compare the proposed runtime-retirement invariant and ordering with issue #4486 and the decisions in #3601 and #3705, including the existing window-protection and fail-closed behavior. Done means a maintainer explicitly approves the rule or requests concrete changes on the pull request.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.