makecindy / makecindy/cindy

维护者确认:PR #4247 本地 Codex 插件运行时 allowlist

Open
#4,249 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

这次改动需要维护者确认(技术架构)。

## 改了什么
Cindy 当前对本地 Codex app-server 一刀切关闭插件运行时(#3160)。PR #4247 保留默认禁用,但新增 Desktop → maker-core 的 `prepareCodexPluginRuntimeConfig` 回调:只对 Cindy 明确允许、用户配置启用且本地缓存存在的 `nowledge-mem@nowledge-community` 打开本地 plugins / hooks;其余已配置插件继续 CLI override 禁用,远程安装保持关闭;准备失败回退全禁用。

涉及文件:
- `packages/maker-core/src/agents/base-agent.ts`:新增跨包 `AgentDeps` 回调契约
- `packages/maker-core/src/agents/codex/index.ts`:本地 spawn 可用该回调替换全禁用参数
- `apps/desktop/src/main/maker-host/index.ts` + `codex-global-plugins.ts`:Desktop 注入 Nowledge 单项放行

## 为何需要确认
这不是同结构内的实现替换。它改变了:
1. maker-core 与 Desktop 之间的跨包 API 形状(新的 spawn 策略回调);
2. 本地 Codex 插件运行时的安全默认(从硬禁用变为 allowlist 例外,并可同时 `--enable hooks`);
3. 宿主对隔离 Codex Home 配置/缓存的读取与 CLI override 生成路径。

作者不是维护者,当前也没有维护者 Approve。请直接在 PR 上 Approve 放行讨论门;若需要作者修改,请 Request Changes。

PR:https://github.com/makecindy/cindy/pull/4247

---
关联 PR:#4247(作者 @jimmy668765);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的技术架构调整,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Review PR #4247 alongside packages/maker-core/src/agents/base-agent.ts, packages/maker-core/src/agents/codex/index.ts, apps/desktop/src/main/maker-host/index.ts, and codex-global-plugins.ts. Start by tracing the new spawn callback and the isolated Codex Home configuration and CLI override paths. Done means the maintainer has decided whether the allowlist exception and cross-package API are safe to approve or require changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, developer-experience, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.