makecindy / makecindy/cindy

维护者确认:PR #4232 项目知识支持 Codex

Open
#4,239 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

PR:https://github.com/makecindy/cindy/pull/4232
Head:`7e4afe76ed26635bb21238525a76f3b8262f4e2b`
作者:ZJPex(非维护者)

## 这次改动

为 `project-context` 新增 Codex CLI adapter,使配置 `agent: codex` 可用已有 Codex 登录执行项目知识 refresh / 小 diff update。默认 Claude Code 路径不变。

## 为何需要维护者确认

当前同时命中三类确认门,均未放行:

1. **产品(当前 blocker)**:`feat` 类型。用户可见变化是知识配置可选择 Codex;失败或非法输出会保留旧正文并标 stale。
2. **安全**:新增第三方依赖 `cross-spawn`、`@types/cross-spawn`、`vitest`。adapter 会从仓库根目录 spawn `codex exec`(含 Windows `.cmd` / 超时回收进程树)。安全门不因 bugfix 或小改动豁免。
3. **架构**:核心路径改动约 735 行,总 diff 834 行。新增 adapter / factory 映射 / cwd 传递,属于模块边界扩展,不是同结构内机械替换。

明确不包含:自动安装登录、custom/Pi adapter、Desktop 生命周期、新 Agent Loop、事实正确性自动校验。

## 请维护者怎么做

请直接在 PR 上 **Approve** 放行讨论门;若需要作者修改,请 **Request Changes**。普通评论或摘标签不算确认。

---
关联 PR:#4232(作者 @ZJPex);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的产品 / UI 变更,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Review PR #4232, starting with the project-context Codex CLI adapter, factory mapping, and cwd handling described in the issue. Check the adapter's cross-spawn process behavior and Vitest coverage, then verify that Codex configuration works without changing the default Claude Code path and that invalid output preserves stale content; completion requires maintainer approval or requested changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ai, cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.