makecindy / makecindy/cindy

维护者确认:PR #3642 新增「中断回合自动继续」设置

Open
#3,644 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

## 为什么需要维护者确认

PR https://github.com/makecindy/cindy/pull/3642 把「被打断的回合是否自动继续」从内部行为改成了用户可改的设置项:设置页 Window Behavior 新增开关,并打通 main 持久化、IPC、preload 与 renderer hook。

这是产品方向变更(新的用户可见设置 + 默认行为可能被用户改掉),不是既有功能的补丁。需要维护者确认:

- 这个开关是否应该出现在设置里、放在 Window Behavior 是否合适
- 默认开/关是否符合现有中断回合产品口径
- 改设置后是否只影响新的中断,还是也改正在跑的任务

## 怎么确认

直接在 PR 上 Approve 即放行。需要修改就 Request Changes,作者改完后再 Approve。

不要只在评论或本 issue 里口头说「可以」——流程只认 PR 上的 Approve。

---
关联 PR:#3642(作者 @PeaceMaker-best);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的产品 / UI 变更,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Review PR #3642 and its Window Behavior setting across the main process, persistence, IPC, preload, and renderer hook. Start by checking the PR’s implementation and the three product questions in this issue. Done means a maintainer approves the PR on GitHub or requests changes; this issue is not an independent coding task.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
backend, desktop, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.