makecindy / makecindy/cindy

维护者确认:#3571 技能预览打开时锁定宿主滚动

Open
#3,588 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

PR #3571(fix(desktop): lock skill preview host scrolling)命中产品 / UI 确认门。

## 为什么需要维护者确认
技能管理页打开预览时,会锁定首页/市场列表宿主滚动容器(overflow-y),关闭后再恢复。这是用户能直接感受到的交互变化:预览打开期间滚轮不再带动父列表。

改动范围:
- SkillhubHomeView / SkillhubMarketListView 把滚动容器 ref 交给预览面板
- SkillhubMarketPreviewPanel 在打开期间调用 useSkillhubPreviewScrollLock

这不是纯内部数据流,也不是零像素差异。请维护者确认该滚动锁定符合技能预览浮层的预期交互。

## 如何确认
- 同意:直接在 PR 上 Approve
- 需要修改:在 PR 上 Request Changes,作者改完后再 Approve 即放行

不要只靠评论或摘标签当作通过。

---
关联 PR:#3571(作者 @nextzhou);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的产品 / UI 变更,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Start with PR #3571 and review the SkillhubHomeView, SkillhubMarketListView, SkillhubMarketPreviewPanel, and useSkillhubPreviewScrollLock references described in this issue. Verify the preview's scroll-lock behavior in the host list, then obtain maintainer approval on the PR; this issue is complete when the PR is approved or changes are requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.