makecindy / makecindy/cindy

维护者确认:#3343 插件 Node worker 空闲回收后再启动

Open
#3,350 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

## 需要维护者确认的点

PR https://github.com/makecindy/cindy/pull/3343 改 `nodeRuntimeBroker`:idle reclaim 后再 fork 前等待旧 UtilityProcess 退出。

插件基座路径改动不走 bugfix 豁免——会作用到全部已装、按需 Node 插件。请维护者确认:

1. 只覆盖 on-demand idle reclaim、不动 resident / stopAndWait / destroyAll 的范围是否正确;
2. draining timeout 失败时不双开、直接启动失败,对存量插件是否可接受;
3. 与同题 #3344 是否应只留一条,避免两套等待语义并存。

## 如何放行

- 同意:直接在 PR 上 **Approve**。
- 要改:在 PR 上 **Request Changes**。

---
关联 PR:#3343(作者 @Battleplus);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的插件基座改动(影响全部已装插件),维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Review PR #3343 and the nodeRuntimeBroker changes first. Check the stated scope for on-demand idle reclaim versus resident, stopAndWait, and destroyAll, then compare the draining-timeout behavior with issue #3344; done means the maintainer’s scope and failure-mode decisions are recorded and the PR can be approved or sent back for changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, node.js, typescript
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.