makecindy / makecindy/cindy

UI 签核门误伤:生成物路径误判为 UI 改动;观感零变化重构缺快速通道

Open
#2,917 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

## 背景

`touches:product-ui` 标触发人工 UI 签核。zqchris 账号下的自动化 PR 作者无法自签,只能等其他维护者,放行以天计。实测发现两类误伤:

## 问题 1:生成物路径误判

纯后端 PR(Windows Git PATH 解析)因重新生成第三方许可声明,改动了 `apps/desktop/resources/THIRD-PARTY-NOTICES.txt` 等生成文件,被按路径判为 UI 改动拦进签核门。

**建议**:打标规则排除生成物路径(`apps/desktop/resources/`、`docs/legal/notices/` 及 SBOM 输出),或以「renderer 组件/样式文件」为准而非目录前缀一刀切。

## 问题 2:观感零变化的重构无快速通道

会话控制面 PR 把侧栏状态点的散装判断切换到统一状态投影(数据源重构),视觉行为一字不变并有行为一致性测试(含远程会话),仍被与真正的 UI 改动同等对待。

**建议**:提供「UI 重构·观感零变化」的声明通道——作者在描述中给出必要性说明+行为一致性测试证据,签核人可按快速通道放行;或由标签区分 `ui-visual-change` 与 `ui-refactor-parity`。

## 期望

- 生成物不再触发 UI 签核;
- 观感零变化重构的签核时间从天级降到分钟级;
- 真正的视觉/交互改动照旧走完整人工签核,不放松。

Contributor guide

Open the contributing guide

Research direction

Start by locating the automation that applies the `touches:product-ui` label and the UI approval gate. Trace how `apps/desktop/resources/`, `docs/legal/notices/`, SBOM outputs, and visual versus parity labels are classified. Done means generated notices no longer trigger approval, parity refactors have a documented fast path, and genuine visual or interaction changes retain full review.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
ci-cd, developer-experience
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.