makecindy / makecindy/cindy

维护者确认:auto-review 根访问契约重构,跨包 API 形状变化(#2565)

Open
#2,579 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
401
Avg merge
21h 48m
Merged PRs (30d)
776

Description

## 背景

PR #2565 把 auto-review 的根访问从隐式 `workspaceRoots: string[]` 重构为显式的 `WorkspaceRootAccess { primaryRoot, readRoots, writableRoots }`,17 个文件、maker-core 三个 agent 家族(claude-code / codex / pi)与 maker-host 的调用点全部随之改动,并新增从 maker-core 公共 index 的导出。

## 为什么需要维护者确认

这是跨包数据契约的形状变化(maker-core ↔ maker-host),auto-review 决策的输入语义从「哪些根」细化为「只读根 / 可写根」,会直接影响 Auto 权限模式的审批行为。属于核心路径上的较大结构调整,需要维护者确认契约设计。

## 确认方式

维护者直接在 PR #2565 上 Approve 即放行;需要修改就 Request Changes,作者改完后重新 Approve。

---
关联 PR:#2565(作者 @zyaoii);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的技术架构调整,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Start with PR #2565 and review the 17 changed files across maker-core and maker-host, including the claude-code, codex, and pi agent families. Check the WorkspaceRootAccess contract and its export from the maker-core public index; this issue is done when a maintainer approves the PR or requests changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.