makecindy / makecindy/cindy

维护者确认:fix(claude): Stop during runtime replay no longer hangs sessions (#2150)

Open
#2,217 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
395
Avg merge
21h 48m
Merged PRs (30d)
776

Description

## 触发原因

arch 门触发:核心路径改动 441 行(≥150 行阈值),涉及 `packages/maker-core/src/agents/claude-code/` 下的 Claude Code harness 流程。

## 改了什么(摘要)

修复 Claude Code 会话在 runtime replay 期间执行 Stop 可能永久卡住的问题:为 send acceptance 窗口增加绑定 Query identity 的单一取消所有者;Stop 可主动唤醒卡住的 send 并封存旧 Query;取消后保留 rewind checkpoint 或标记 fresh rebuild。

## 需要确认什么

请维护者确认此改动的架构方向是否正确,尤其是:
1. Query identity 绑定取消所有权的设计是否合理
2. rewind checkpoint / fresh rebuild 的状态机变更是否引入新的边界情况

## 如何确认

- **同意**:直接在 PR 上点 **Approve**,下一轮 auto-review 自动放行
- **需要修改**:在 PR 上提交 **Request Changes** 并说明需要改什么,作者改完后重新 Approve 即放行
- **讨论**:在本 issue 中讨论

> ⚠️ 注意:此 PR 当前与 main 有合并冲突,请作者先解决冲突。

---
关联 PR:#2150(作者 @mengfanyu9410-hub);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的技术架构调整,维护者确认后 PR 会恢复推进。

Contributor guide

Open the contributing guide

Research direction

Start with PR #2150 and inspect the Claude Code harness flow under packages/maker-core/src/agents/claude-code/. Review the query-identity cancellation ownership and the rewind checkpoint/fresh rebuild state-machine changes, then check the PR’s merge-conflict status. Done means a maintainer approves the architecture or requests specific changes for the author.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ai, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
18/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.