维护者确认:侧栏 OAuth 弹窗修复涉及安全敏感代码(navigation-escape ×3)
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 395
- Avg merge
- 21h 48m
- Merged PRs (30d)
- 776
Description
## 变更
PR #2132 fix(desktop): 避免侧栏分离期间丢失 OAuth 弹窗,作者 @mengfanyu9410-hub。
## 触发确认的原因
1. **security**:命中 3 处 navigation-escape 危险写法,涉及窗口导航安全边界
2. **product**:命中 UI 路径 `apps/desktop/src/renderer/features/right-sidebar/lib/popupRouter.ts`
3. **arch**:核心路径改动 1251 行(≥150),总 diff 1256 行(≥800)
## 需要确认
请维护者审查安全敏感改动是否可接受。确认方式:
- 在 PR 上 **Approve** 即放行
- 需要修改就 **Request Changes**,作者改完后重新 Approve 即放行
---
关联 PR:#2132(作者 @mengfanyu9410-hub);本 issue 由 review-pr 流程自动创建,用于先讨论该 PR 涉及的产品 / UI 变更,维护者确认后 PR 会恢复推进。
Contributor guide
Research direction
Review PR #2132 and the security-sensitive changes in apps/desktop/src/renderer/features/right-sidebar/lib/popupRouter.ts. Start by checking the three navigation-escape occurrences and the 1,251-line core-path diff. Done means the maintainer has confirmed the security and UI changes are acceptable and approved the PR.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- authentication, desktop, security
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100