mailgun / mailgun/node-prelaunch

Error on launch with deploy button

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
229
Forks
32
PR merge metrics
No merged PRs in 30d

Description

I clicked the launch button, then filled out the form and this showed up in the logs, with an application error on the main page.

```2018-07-21T01:51:33.516523+00:00 app[web.1]: > node-prelaunch@1.0.0 start /app
2018-07-21T01:51:33.516525+00:00 app[web.1]: > node server
2018-07-21T01:51:37.049938+00:00 app[web.1]:
2018-07-21T01:51:37.050308+00:00 app[web.1]: /app/node_modules/email-templates/node_modules/juice/node_modules/web-resource-inliner/src/html.js:50
2018-07-21T01:51:37.051150+00:00 app[web.1]: result = result.replace( re, () => html );
2018-07-21T01:51:37.052242+00:00 app[web.1]: ^
2018-07-21T01:51:37.058962+00:00 app[web.1]: SyntaxError: Unexpected token )
2018-07-21T01:51:37.058965+00:00 app[web.1]: at Module._compile (module.js:439:25)
2018-07-21T01:51:37.058967+00:00 app[web.1]: at Object.Module._extensions..js (module.js:474:10)
2018-07-21T01:51:37.058968+00:00 app[web.1]: at Module.load (module.js:356:32)
2018-07-21T01:51:37.058970+00:00 app[web.1]: at Function.Module._load (module.js:312:12)
2018-07-21T01:51:37.058971+00:00 app[web.1]: at Module.require (module.js:364:17)
2018-07-21T01:51:37.058973+00:00 app[web.1]: at require (module.js:380:17)
2018-07-21T01:51:37.058975+00:00 app[web.1]: at Object. (/app/node_modules/email-templates/node_modules/juice/node_modules/web-resource-inliner/src/inline.js:15:15)
2018-07-21T01:51:37.058976+00:00 app[web.1]: at Module._compile (module.js:456:26)
2018-07-21T01:51:37.058978+00:00 app[web.1]: at Object.Module._extensions..js (module.js:474:10)
2018-07-21T01:51:37.058979+00:00 app[web.1]: at Module.load (module.js:356:32)
2018-07-21T01:51:37.058980+00:00 app[web.1]: at Function.Module._load (module.js:312:12)
2018-07-21T01:51:37.058982+00:00 app[web.1]: at Module.require (module.js:364:17)
2018-07-21T01:51:37.058984+00:00 app[web.1]: at require (module.js:380:17)
2018-07-21T01:51:37.058986+00:00 app[web.1]: at Object. (/app/node_modules/email-templates/node_modules/juice/index.js:11:14)
2018-07-21T01:51:37.058987+00:00 app[web.1]: at Module._compile (module.js:456:26)
2018-07-21T01:51:37.058989+00:00 app[web.1]: at Object.Module._extensions..js (module.js:474:10)
2018-07-21T01:51:37.058990+00:00 app[web.1]: at Module.load (module.js:356:32)
2018-07-21T01:51:37.058992+00:00 app[web.1]: at Function.Module._load (module.js:312:12)
2018-07-21T01:51:37.058993+00:00 app[web.1]: at Module.require (module.js:364:17)
2018-07-21T01:51:37.058995+00:00 app[web.1]: at require (module.js:380:17)
2018-07-21T01:51:37.058996+00:00 app[web.1]: at Object. (/app/node_modules/email-templates/lib/email-template.js:21:14)
2018-07-21T01:51:37.058998+00:00 app[web.1]: at Module._compile (module.js:456:26)
2018-07-21T01:51:37.058999+00:00 app[web.1]: at Object.Module._extensions..js (module.js:474:10)
2018-07-21T01:51:37.059001+00:00 app[web.1]: at Module.load (module.js:356:32)
2018-07-21T01:51:37.059002+00:00 app[web.1]: at Function.Module._load (module.js:312:12)
2018-07-21T01:51:37.059004+00:00 app[web.1]: at Module.require (module.js:364:17)
2018-07-21T01:51:37.059006+00:00 app[web.1]: at require (module.js:380:17)
2018-07-21T01:51:37.059007+00:00 app[web.1]: at Object. (/app/node_modules/email-templates/lib/main.js:7:21)
2018-07-21T01:51:37.075731+00:00 app[web.1]:
2018-07-21T01:51:37.086718+00:00 app[web.1]: npm ERR! Linux 4.4.0-1019-aws
2018-07-21T01:51:37.087174+00:00 app[web.1]: npm ERR! argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "start"
2018-07-21T01:51:37.087538+00:00 app[web.1]: npm ERR! node v0.10.48
2018-07-21T01:51:37.090352+00:00 app[web.1]: npm ERR! npm v2.15.1
2018-07-21T01:51:37.090662+00:00 app[web.1]: npm ERR! code ELIFECYCLE
2018-07-21T01:51:37.090897+00:00 app[web.1]: npm ERR! node-prelaunch@1.0.0 start: `node server`
2018-07-21T01:51:37.091141+00:00 app[web.1]: npm ERR! Exit status 8
2018-07-21T01:51:37.091399+00:00 app[web.1]: npm ERR!
2018-07-21T01:51:37.091899+00:00 app[web.1]: npm ERR! Failed at the node-prelaunch@1.0.0 start script 'node server'.
2018-07-21T01:51:37.092160+00:00 app[web.1]: npm ERR! This is most likely a problem with the node-prelaunch package,
2018-07-21T01:51:37.092388+00:00 app[web.1]: npm ERR! not with npm itself.
2018-07-21T01:51:37.092606+00:00 app[web.1]: npm ERR! Tell the author that this fails on your system:
2018-07-21T01:51:37.092834+00:00 app[web.1]: npm ERR! node server
2018-07-21T01:51:37.093048+00:00 app[web.1]: npm ERR! You can get information on how to open an issue for this project with:
2018-07-21T01:51:37.093305+00:00 app[web.1]: npm ERR! npm bugs node-prelaunch
2018-07-21T01:51:37.093575+00:00 app[web.1]: npm ERR! Or if that isn't available, you can get their info via:
2018-07-21T01:51:37.094000+00:00 app[web.1]: npm ERR!
2018-07-21T01:51:37.094253+00:00 app[web.1]: npm ERR! npm owner ls node-prelaunch
2018-07-21T01:51:37.094477+00:00 app[web.1]: npm ERR! There is likely additional logging output above.```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the launch flow with the `npm start`/`node server` entry point and inspect the reported syntax error in `node_modules/email-templates/node_modules/juice/node_modules/web-resource-inliner/src/html.js`. Trace the dependency versions against the reported Node v0.10.48 runtime; done means the launch flow starts without this error and the main page loads.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.