mailgun / mailgun/groupcache

Upgrade the Protobuf API version

Open
#62 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
539
Forks
76
PR merge metrics
No merged PRs in 30d

Description

The [Protobuf API](https://pkg.go.dev/github.com/golang/protobuf/proto) used in this project is already outdated and cannot be used for Protobuf definitions that are compiled using a recent version of `protoc-gen-go` which uses [this package](https://pkg.go.dev/google.golang.org/protobuf/proto) instead.

Is there any plan to upgrade this? I can create a PR for this as I already upgraded it in [my fork](https://github.com/adzil/groupcache/pull/1) although I understand that this may break backward compatibility with the existing `mailgun/groupcache/v2` API.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the project's current use of github.com/golang/protobuf/proto with google.golang.org/protobuf/proto, then review the linked fork pull request for the proposed upgrade. Determine the compatibility impact on the mailgun/groupcache/v2 API and verify that existing behavior and recent protoc-gen-go-generated definitions both work before considering the change complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.