mailgun / mailgun/godebug

Functions defined as part of an array or slice literal are not instrumented

Open
#73 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
2.5k
Forks
102
PR merge metrics
No merged PRs in 30d

Description

I have a VM I am working on that uses an array of functions to handle opcodes. Unfortunately these functions are not instrumented. I tried changing the array to a slice, with the same result.

This bug probably effects map and struct literals as well...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a VM whose opcode handlers are functions in an array and then in a slice literal. Trace the instrumentation path to determine why these functions are skipped; done means functions defined in array and slice literals are instrumented, with map and struct literals considered if the same cause applies.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.