mailgun / mailgun/flanker

Inline attachment filename not detected

Open Beginner friendly
#44 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
1.6k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

The culprit is this piece of code in flanker/mime/message/part.py:

``` python
def detected_file_name(self):
...
cdisp = self.content_disposition
if cdisp.value == 'attachment':
file_name = cdisp.params.get('filename', '') or file_name
```

It doesn't check `inline` content disposition

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in flanker/mime/message/part.py at detected_file_name and inspect how content disposition parameters are handled for inline parts. Reproduce an inline Content-Disposition carrying a filename, then verify the method returns that filename while preserving existing attachment behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.