mailgun / mailgun/flanker

Allow address.parse() to reject addresses with local hostnames

Open
#201 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.6k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

address.parse() currently accepts addresses with a single-part domain as used for a local mail host, e.g. bleah@example. I am currently working on a use case where we would only want to send to Internet addresses, like bleah@example.com or bleah@foo.example.com. It would be useful to have an option to reject addresses with single-part domains.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the address.parse() entry point and trace how it validates the domain portion of an address. Define how an option should identify single-part domains such as example, then add coverage for accepting normal Internet domains and rejecting local hostnames when that option is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.