magicblock-labs / magicblock-labs/magicblock-validator

Transaction preparation can panic in committor workers

Open
#1,018 0 comments 0 reactions 1 assignee View on GitHub

@snawaz is already working on this.

Since Sep 9, 2026.

bug
Dominant language
Rust
Stars
58
Forks
58
Avg merge
22h 1m
Merged PRs (30d)
53

Description

## Problem

**Report**
What happened:
In `magicblock-committor-service/src/transaction_preparator/mod.rs` at line 106, there is a `.expect()` call that can cause a runtime panic in committor workers:
```rust
let message = TransactionUtils::assemble_tasks_tx(
authority,
&tx_strategy.optimized_tasks,
self.compute_budget_config.compute_unit_price,
&lookup_tables,
)
.expect("Possibility to assemble checked above")
.message;
```

Expected:
Error should be propagated via `?` through the existing `PreparatorResult` error path instead of panicking.

Repro:
The lookup tables passed to the second `assemble_tasks_tx` call may differ from the first check at line 86, making the assumption in `.expect()` not strictly guaranteed.

Logs/links:
https://github.com/magicblock-labs/magicblock-validator/blob/master/magicblock-committor-service/src/transaction_preparator/mod.rs#L106

I'd like to work on this fix if no one is assigned yet.

**Commit / version**
master

**Environment**
_No response_

## Reproduction

Not yet documented.

## Expected

The affected flow completes without the described failure.

## Context

Add the affected revision and path when known.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.