magicblock-labs / magicblock-labs/delegation-program

Implement FinalizeCommitment

Open
#224 0 comments 0 reactions 1 assignee View on GitHub

@snawaz is already working on this.

Since Sep 17, 2026.

Dominant language
Rust
Stars
30
Forks
21
Avg merge
20m
Merged PRs (30d)
1

Description

### Scope

- On the happy path, require a closed challenge window, the approval threshold, and no unresolved challenge.
- After dispute resolution, use the state source recorded by the resolver, not a caller-selected alternative.
- Require a finalized buffer bound to the correct account, commit id, and authority, and verify the full-state hash before applying lamports, owner, and data.

Under-approved commitments and unresolved challenges must not bypass these checks.

Design: [v2 implementation notes](https://github.com/magicblock-labs/delegation-program/blob/36e1efae94660460fdc6d823afb1fbc4c504e8a6/mimd-0024-impl.md#important-instruction-rules).

### Outcome

Apply the eligible operator or resolver-selected account state through `FinalizeCommitment`.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.