magicblock-labs / magicblock-labs/Solana.Unity-SDK

[Bug] iconUri is constructed with new Uri(iconUri, UriKind.Relative)

Open Beginner friendly
#291 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C#
Stars
199
Forks
128
PR merge metrics
No merged PRs in 30d

Description

I found that iconUri is constructed with new Uri(iconUri, UriKind.Relative), which rejects absolute URLs. Since the Unity Inspector doesn't mention this requirement, it's easy to configure an absolute URL and spend hours debugging why Phantom continues to show the default SDK branding (solana.unity-sdk.gg / Solana.Unity-SDK). Could the SDK either support absolute URLs or validate and log a clear error when an invalid iconUri is supplied?

Contributor guide

Open the contributing guide

Research direction

Search the SDK for `new Uri(iconUri, UriKind.Relative)` and inspect how `iconUri` is supplied through the Unity Inspector. Reproduce the behavior with an absolute URL, then verify that absolute URLs work or that invalid values produce a clear validation error and log message.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, unity
Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.