magic-wormhole / magic-wormhole/fowl
factor "shutdown" flow into one place
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 163
- Forks
- 14
- Avg merge
- 14h 58m
- Merged PRs (30d)
- 3
Description
If the "nice shutdown" flow actually works well, factor it into `FowlWormhole.close_wormhole` (or similar). If it doesn't (or if it goes in magic-wormhole itself) then delete it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing "nice shutdown" flow and `FowlWormhole.close_wormhole`. Trace whether that flow works correctly here or belongs in magic-wormhole, then compare the relevant shutdown behavior before choosing a direction. Done means the working shutdown path is centralized in `close_wormhole`, or the unused flow is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100