DHL Carrier Wrong Service Type Variable Displayed in Tracking Popup
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 12.2k
- Forks
- 9.4k
- PR merge metrics
- No merged PRs in 30d
Description
### Preconditions and environment
- Magento Version 2.0.0 - 2.4.9
***
### Functional Testing Scenario 1: (Shipment with description)
#### Steps to reproduce
1. Configure the DHL shipping/delivery method using valid API credentials.
2. Make sure that the "Content Type (Non Domestic)" configuration field is set to "Non documents", if applicable.
3. Add any non-virtual product to a shopping cart.
4. Place an order with a shipping address.
5. Create a shipment for the order.
7. Add a valid DHL tracking number **for a shipment with description**, selecting DHL under the Carrier column.
8. Open the shipment Tracking Information popup for the order.
#### Expected result
The DHL product title is displayed as the Service Type.
#### Actual result
The DHL shipment description is displayed as the Service Type.
***
### Functional Testing Scenario 2: (Shipment without description)
#### Steps to reproduce
1. Configure the DHL shipping/delivery method using valid API credentials.
2. Make sure that the "Content Type (Non Domestic)" configuration field is set to "Non documents", if applicable.
3. Add any non-virtual product to a shopping cart.
4. Place an order with a shipping address.
5. Create a shipment for the order.
7. Add a valid DHL tracking number **for a shipment without description**, selecting DHL under the Carrier column.
8. Open the shipment Tracking Information popup for the order.
#### Expected result
The DHL product title is displayed as the Service Type.
#### Actual result
The Service Type is not displayed.
***
### Additional information
The DHL product title can be obtained by using the GlobalProductCode variable, instead of the ShipmentDesc variable, and passing it to the Magento\Dhl\Model\Carrier::getDhlProductTitle() function.
### Release note
Fixed: The DHL shipment description was used as the Service Type instead of the DHL product title in the shipment Tracking Information popup.
### Triage and priority
- [ ] Severity: **S0** _- Affects critical data or functionality and leaves users without workaround._
- [ ] Severity: **S1** _- Affects critical data or functionality and forces users to employ a workaround._
- [ ] Severity: **S2** _- Affects non-critical data or functionality and forces users to employ a workaround._
- [x] Severity: **S3** _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [x] Severity: **S4** _- Affects aesthetics, professional look and feel, “quality” or “usability”._
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Magento\Dhl\Model\Carrier::getDhlProductTitle() and trace how the DHL tracking response populates the shipment Tracking Information popup. Verify the GlobalProductCode is used instead of ShipmentDesc for both shipments with and without descriptions, then exercise the two functional scenarios to confirm the DHL product title appears as the Service Type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100