magento / magento/magento2

[Issue] Wrong method used to get attribute code in product comparison attribute list

Open
#36,933 9 comments 0 reactions 1 assignee Assigned to @nicolas-medina View on GitHub
Area: Product Component: Attributes Issue: Confirmed Priority: P3 Progress: PR in progress Reported on 2.4.x Reproduced on 2.4.x Triage: Dev.Experience
Dominant language
PHP
Stars
12.2k
Forks
9.4k
PR merge metrics
No merged PRs in 30d

Description

This issue is automatically created based on existing pull request: magento/magento2#36929: Wrong method used to get attribute code in product comparison attribute list

---------
### Description (*)
Wrong method used to get attribute code in product comparison attribute list.

### Related Pull Requests

### Fixed Issues (if relevant)

### Manual testing scenarios (*)
1. Add product to comparison list
2. Go to comparison list
3. Inspect price line in attribute list
4. Element ID of price is now correct (product-price-1234-compare-list-price instead of product-price-1234-compare-list-)

### Questions or comments

### Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [ ] All commits are accompanied by meaningful commit messages
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
- [ ] README.md files for modified modules are updated and included in the pull request if any [README.md predefined sections](https://github.com/magento/devdocs/wiki/Magento-module-README.md) require an update
- [ ] All automated tests passed successfully (all builds are green)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.