Wrong name conversion on getCustomerRegisterUrlUrl() at AuthenticationPopup.php
Open
@Vasudev-22 is already working on this.
Since Jan 31, 2023.
Area: Framework
Component: Code
Issue: Confirmed
Priority: P3
Progress: PR in progress
Reported on 2.4.x
Reproduced on 2.4.x
- Dominant language
- PHP
- Stars
- 12.2k
- Forks
- 9.4k
- PR merge metrics
- No merged PRs in 30d
Description
Preconditions and environment
- Magento Magento 2.4.(*)
Steps to reproduce
Steps:
Check all Magento 2.4.x and all other Magento 2.3.X versions.
Function name is wrong on method \Magento\Customer\Block\Account\AuthenticationPopup::getCustomerRegisterUrlUrl as per Magento name conversion.
/**
* Get customer register url
*
* @return string
*/
public function getCustomerRegisterUrlUrl()
{
return $this->getUrl('customer/account/create');
}
Expected result
Method name should be getCustomerRegisterUrl The method
Actual result
Method name is now getCustomerRegisterUrlUrl The method
Additional information
Also need to change at method getCustomerRegisterUrlUrl;
/**
* Returns popup config
*
* @return array
*/
public function getConfig()
{
return [
'autocomplete' => $this->escapeHtml($this->isAutocompleteEnabled()),
'customerRegisterUrl' => $this->escapeUrl($this->getCustomerRegisterUrlUrl()),
'customerForgotPasswordUrl' => $this->escapeUrl($this->getCustomerForgotPasswordUrl()),
'baseUrl' => $this->escapeUrl($this->getBaseUrl()),
'customerLoginUrl' => $this->getUrl('customer/ajax/login'),
];
}
Release note
No response
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.
- Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
- Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
- Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
- Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.