Auto generated code needs to be marked as API
Open
@DenisSaltanahmedov is already working on this.
Since Apr 1, 2021.
feature request
Priority: P1
Progress: dev in progress
Project: API Changes
Severity: S1
- Dominant language
- PHP
- Stars
- 12.2k
- Forks
- 9.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description
Auto-generated code needs to be marked as API
Details
- Auto generated code needs to be marked as @api:
- \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceFactoryGenerator
- \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceGenerator
- \Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator
- \Magento\Framework\MessageQueue\Code\Generator\RemoteServiceGenerator
- Factories generated for @api entities must also be marked as @api. Factories for non-@api must not be marked as @api
- \Magento\Framework\ObjectManager\Code\Generator\Factory
Testing
Run bin/magento setup:di:compile
Check the generated classes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.