magento / magento/magento2-functional-testing-framework

Allow use of Credentials as ActionGroup Argument

Open
#880 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
154
Forks
134
PR merge metrics
No merged PRs in 30d

Description

### Preconditions

1. MFTF version 3.5.0

### Steps to reproduce

Trying an ActionGroup like this
<actionGroup ref="AlternateAdminLoginActionGroup" stepKey="loginAsAdmin">
<argument name="username" value="{{_ENV.MAGENTO_ADMIN_USERNAME}}"/>
<argument name="password" value="{{_CREDS.admin_password}}"/>
</actionGroup>

### Expected result

1. Test is generated and Run without problems

### Actual result

1. Test is not Generated
Error Log reports
[2022-01-05 08:19:11] Magento\FunctionalTestingFramework\Util\TestGenerator.ERROR: Line 277: You cannot reference secret data outside of the fillField, magentoCLI and createData actions in Test

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in MFTF 3.5.0 using the shown ActionGroup arguments and the {{_CREDS.admin_password}} reference. Start from the TestGenerator error at line 277 and trace the validation of ActionGroup arguments. Done means the test is generated and runs without the secret-data error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.