magento / magento/magento-coding-standard
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 375
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
### Preconditions
- phpcs v3.13.2
- magento coding standard 38
### Steps to reproduce
1. use versions from above
2. run phpcs against magento
### Expected result
No deprecation warnings
### Actual result
```
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
The Magento2.GraphQL.ValidArgumentName sniff is listening for GRAPHQL.
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
The Magento2.GraphQL.ValidFieldName sniff is listening for GRAPHQL.
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
The Magento2.GraphQL.ValidTopLevelFieldName sniff is listening for GRAPHQL.
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
The Magento2.GraphQL.ValidTypeName sniff is listening for GRAPHQL.
DEPRECATED: Support for custom tokenizers will be removed in PHP_CodeSniffer 4.0.
The Magento2.GraphQL.ValidEnumValue sniff is listening for GRAPHQL.
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the warnings with PHP_CodeSniffer v3.13.2 and Magento Coding Standard 38 by running phpcs against Magento. Inspect the custom-tokenizer handling and the listed Magento2.GraphQL sniffs. Done means the GraphQL checks still work without the PHP_CodeSniffer 4.0 deprecation warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100