magento / magento/magento-coding-standard

DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.

Open
#497 2 comments 9 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
375
Forks
165
PR merge metrics
No merged PRs in 30d

Description

### Preconditions

- phpcs v3.13.2
- magento coding standard 38

### Steps to reproduce

1. use versions from above
2. run phpcs against magento theme

### Expected result

No deprecation warnings

### Actual result

```
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.ClassNaming sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.Variables sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.PropertiesSorting sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.ColonSpacing sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.PropertiesLineBreak sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.ZeroUnits sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.AvoidId sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.TypeSelectors sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.ImportantProperty sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.CommentLevels sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.CombinatorIndentation sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.SelectorDelimiter sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.TypeSelectorConcatenation sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.ColourDefinition sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.Quotes sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.SemicolonSpacing sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.BracesFormatting sniff is listening for CSS.
DEPRECATED: Scanning CSS/JS files is deprecated and support will be removed in PHP_CodeSniffer 4.0.
The Magento2.Less.Indentation sniff is listening for CSS.
```

Contributor guide

Open the contributing guide

Research direction

Run phpcs v3.13.2 with Magento coding standard 38 against a Magento theme and review the deprecation output for the listed Magento2.Less sniffs. Done means scanning the theme no longer produces the reported CSS/JS deprecation warnings while the relevant checks still run.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript, php
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.