magento / magento/magento-coding-standard
Too strict or early rule for Zend_Validate
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 375
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
### Steps to reproduce
1. Use Zend_Validate in your extension
2. Validate extension with the last (26) version of Magento Coding Standard
### Expected result
1. Extension is not valid and there is a correct suggestion or it is not ERROR level but WARNING
2. Suggested replacement is present in 2.4.0 Magento versions as it is [supported to November 28, 2022](https://experienceleague.adobe.com/docs/commerce-operations/release/lifecycle-policy.html)
### Actual result
1. Extension not valid
2. Suggested replacement (\Magento\Framework\Validator\ValidatorChain) is missing in 2.4.0-2.4.5
Pull request #420 bring these new changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Zend_Validate rule changes introduced by pull request #420 and how Magento Coding Standard version 26 reports the violation. Check compatibility with Magento 2.4.0–2.4.5; done means supported extensions are not incorrectly rejected, or receive a warning with a valid replacement suggestion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100