magento / magento/magento-coding-standard
Cannot switch to latest coding standard
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 375
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
Hi!
On Magento 2.4.3, I'm looking to upgrade to latest magento-coding-standard (v25), however, there's a conflict with webonyx/graphql-php.
```
"require": {
"php": ">=7.3",
"webonyx/graphql-php": "^14.9",
```
My Magento version is stuck with v0.13.9, so I'm effectively unable to check against up-to-date code styles and stuck with standards v6.
I believe that coding standard should not technically depend on that, and we can safely remove any Magento **code** version requirements.
Agree?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by inspecting the package's dependency declarations, especially the Magento code requirements and webonyx/graphql-php constraint. Verify whether the latest coding standard can install with the stated PHP and Magento versions, then run the available package checks to confirm the dependency change is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100