magento / magento/magento-coding-standard
Magento2.Legacy.InstallUpgrade.ObsoleteUpgradeSchemaScript ERROR on --severity=10
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 375
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
Magento2.Legacy.InstallUpgrade.ObsoleteUpgradeSchemaScript rule fails on marketplace with ERROR on on --severity=10 application submission.
-
Marketplace allows you to submit packages supporting 2.2 where UpgradeSchemaScript was not obsolete yet
-
Before Magento 2.3, extension developers were required to write code (PHP scripts) to change the database schema.
-
Until marketplace removes 2.2 support this rule is too strict
-
Instead of declaring this as ERROR leave it as legacy/deprecated , then extension providers can support broader range of installations within one single package (cost effective) and included setup scripts would be just dead weight to higher versions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Magento2.Legacy.InstallUpgrade.ObsoleteUpgradeSchemaScript rule and inspect how its severity is assigned. Check the existing rule tests, if present, and update the behavior so packages supporting Magento 2.2 are not blocked by an ERROR for legacy upgrade schema scripts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100