magento / magento/magento-cloud-docker

Mailhog container missing when using .magento.docker.yml

Open
#380 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
277
Forks
187
PR merge metrics
No merged PRs in 30d

Description

Behavior of Mailhog differs when using different configuration methods. When using the `.magento` directory for configuration it's not necessary to explicitly define Mailhog. Mailhog will be included by default. Confusingly, when using the `.magento.docker.yml` for configuration, it's necessary to define a Mailhog container.

This also violates the `build:compose` command interface, which contains a `--no-mailhog` option. A Mailhog container should be generated by default in all situations, unless the `--no-mailhog` option is utilized.

### Preconditions
Using a .magento.docker.yml configuration file without a Mailhog definition

### Steps to reproduce
Run `build:compose` close to default. Eg. `vendor/bin/ece-docker build:compose --mode=developer --sync-engine=native --with-xdebug`

### Expected result
The generated Docker configuration would include a Mailhog container.

### Actual result
The generated Docker configuration dosen't include a Mailhog container.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the build:compose command and compare how .magento configuration and .magento.docker.yml are processed, using the reproduction command in the issue. Verify the generated Docker configuration for a Mailhog container with no explicit definition, and confirm that --no-mailhog still omits it.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, php
Domain
build-system, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.