magento / magento/m2-devtools

composer.json missing dual-license

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
171
Forks
47
PR merge metrics
No merged PRs in 30d

Description

## This issue is a:

- [X] Bug
- [ ] Feature suggestion
- [ ] Documentation issue
- [ ] Other (Please Specify)

### Environment

| Question | Answer |
| --------------------------- | :-----------: |
| Magento version | N/A |
| Browser + version | N/A |
| node.js version (`node -v`) | N/A |
| npm version (`npm -v`) | N/A |

## Description

The root of this repository has 2 licenses, as the code is dual-licensed with OSL and AFL. `composer.json` is missing `AFL`.

## Expected result:

The `license` option in `composer.json` should match [what we use in core](https://github.com/magento/magento2/blob/e5c1527902e1cb69ef4da0e4ff50b25355068813/app/code/Magento/Backend/composer.json#L31-L34). Thanks @pdohogne-magento for catching that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the root composer.json and compare its license option with the Magento core composer.json linked in the issue. Update the metadata so it includes the missing AFL license alongside OSL, then verify the resulting license declaration matches core.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.