magento / magento/m2-devtools

Tracking of customer account pages not working

Open
#45 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
171
Forks
47
PR merge metrics
No merged PRs in 30d

Description

This issue is a:

  • Bug
  • Feature suggestion
  • Documentation issue
  • Other (Please Specify)
Environment
Question Answer
Magento version 2.3.0
Browser + version N/A
node.js version (node -v) N/A
npm version (npm -v) N/A

Description

When clicking around in "Record" mode for the RequireJS Bundle Config generator, results are not captured for customer account pages (reported by @davidverholen).

This is very likely the result of a heuristic that is not 100% correct, and we do not surface that error anywhere in the UI.

Expected result:

The fix for this should be to extend _getPageConfigType in interop.ts to have a more reliable heuristic.

Note: A hard requirement of fixing this will be that it does not require installing any additional modules. One of the goals of the Bundle Generator is to be able to generate config with 0 changes to the Magento store.

Possible solutions:

We can add in some additional heuristics for pages that don't match the pattern being looked for in _getPageConfigType. An example would be a hardcoded list of pages that we can't find the layout handle for, and some additional checks to figure them out.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with _getPageConfigType in src/interop.ts, especially the heuristic linked in the issue, and inspect the error handling in src/RequireJS/BundleGenerator/PageCollector.ts. Reproduce Record mode on customer account pages and trace why results are not captured. Done means those pages are tracked reliably without additional modules and the relevant error is surfaced in the UI.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.