magento / magento/inventory

"Quote does not have Pickup Location assigned." in Instant Purchase with Pickup Store

Open
#3,267 25 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Progress: ready for grooming
Dominant language
PHP
Stars
357
Forks
262
PR merge metrics
No merged PRs in 30d

Description

Hello guys,

we developed a payment module with the Vault feature(https://github.com/dholidev/module-payu). Instant Purchase worked perfectly well with the other shipping methods, however, when using the new **"Pickup Store"** feature of **Magento 2.4.0**, it is not possible to finalize the purchase on the product page. We are getting the message **"Quote does not have Pickup Location assigned."**.

Looking at the documentation below, I found no restrictions to finalize the purchase using "Instant Purchase" with "Pickup Store".

- https://docs.magento.com/user-guide/shipping/shipping-in-store-delivery.html

- https://docs.magento.com/user-guide/sales/checkout-instant-purchase.html

- https://devdocs.magento.com/guides/v2.4/payments-integrations/base-integration/integration-intro.html

- https://devdocs.magento.com/guides/v2.4/payments-integrations/vault/vault-intro.html

Looking at the source code of the Magento\InventoryInStorePickupQuote\Model\Quote\ValidationRule\InStorePickupQuoteValidationRule file, line 116, the value returned from $address->getExtensionAttributes()->getPickupLocationCode() is empty.

As it is not the function of the Payment Method to set the value to "PickupLocationCode", I ask you if this is a bug in Magento 2.4.0 or a limitation like "Instant Purchase cannot be used with Braintree Credit Cards if 3D Secure is enabled. " found at this link https://docs.magento.com/user-guide/sales/checkout-instant-purchase.html.

You can reproduce the error with this product https://payu.dholi.dev/joust-duffle-bag.html, using the test cards from this link https://docs.dholi.dev/en/payu/sandbox.

Best Regards,
Rodrigo

![error](https://user-images.githubusercontent.com/55707463/106367141-405e7400-631f-11eb-8881-f63055866fc6.jpg)
![InStorePickupQuoteValidationRule](https://user-images.githubusercontent.com/55707463/106367148-47858200-631f-11eb-9137-4e3e02d94a57.jpg)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Magento\InventoryInStorePickupQuote\Model\Quote\ValidationRule\InStorePickupQuoteValidationRule around line 116 and reproduce the Instant Purchase flow with Pickup Store using the linked product and test cards. Determine whether PickupLocationCode should be set for this flow or whether the combination is unsupported; done means the behavior is resolved or the limitation is clearly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, payments
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.