magento / magento/inventory

IsProductSalable/AreProdustsSalable composite products support.

Open
#3,140 0 comments 0 reactions 1 assignee View on GitHub

@novikor is already working on this.

Since Nov 15, 2020.

  • #3088 by @novikor — merged
  • #3202 by @novikor — closed without merging
Progress: PR created
Dominant language
PHP
Stars
357
Forks
262
PR merge metrics
No merged PRs in 30d

Description

Description (*)

Currently, IsProductSalable/AreProdustsSalable services do not support bundle and configurable product types.

The relevant logic should be moved from Magento\InventoryBundleProduct\Plugin\CatalogInventory\Helper\Stock\AdaptAssignStatusToProductPlugin and Magento\InventoryCatalog\Plugin\CatalogInventory\Helper\Stock\AdaptAssignStatusToProductPlugin

Expected behavior (*)

IsProductSalable/AreProdustsSalable services DO support bundle and configurable product types.

Benefits
  • Performance improvements: it makes us able to use indexed salability status instead of calculating it each time after a product is loaded;
  • Service Contracts are working as expected, - and support all the product types.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.