magento / magento/ece-tools

Use composer config bin-dir path instead of static vendor/bin folder for shell command apply patches

Open
#823 0 comments 2 reactions 0 assignees View on GitHub
Progress: ready for grooming
Dominant language
PHP
Stars
119
Forks
81
PR merge metrics
No merged PRs in 30d

Description

ece-tools execute shell command `php ./vendor/bin/ece-patches apply --no-interaction` for apply patches, with static path for binaries, in vendor/bin.

It would be great, for the developer experience (better to use custom bin-dir 'bin' at the root directory of project), to use the composer bin-dir config instead of static path.

```php
use Composer\Composer;

private readonly Composer $composer,

$this->composer->getConfig()->get('bin-dir')
```

Contributor guide

Open the contributing guide

Research direction

Locate the ece-tools code that assembles the shell command for applying patches, then read how the Composer instance is available there. Replace the static vendor/bin path with Composer's configured bin-dir and verify that custom bin-dir values produce the expected command.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
cli, developer-experience
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.