magento / magento/directive-parser

Single-line comments in files break parser

Open
#9 0 comments 0 reactions 1 assignee View on GitHub

@zetlen is already working on this.

Since Apr 16, 2020.

bug
Dominant language
JavaScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Even after the directive statement, any single-line `//` comment breaks parse.

See https://github.com/magento/pwa-studio/issues/2239

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.