magento / magento/data-migration-tool

Wrong Migration of catalog/seo/product_url_suffix and catalog/seo/category_url_suffix

Open
#814 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
339
Forks
195
PR merge metrics
No merged PRs in 30d

Description

### Preconditions

1. Magento 1.9.4.4
2. Magento 2.3.4
3. Data Migration Tool 2.3.4

### Steps to reproduce

1. Set the config under the path `catalog/seo/product_url_suffix` to `/`
2. Migrate the settings with the data migration tool
3. Check the migrated value of `catalog/seo/product_url_suffix`

### Expected result

1. I would assume, that the value remains `/`

### Actual result

1. The migrated value is `./`

### Additional notes
The function, which handles that is `\Migration\Handler\Settings\UrlSuffix::handle` The dot is added there, but I can not really understand why this is done.
It actually leads to wrong entries in url_rewrite table, as soon as one adds a new product.

Contributor guide

Open the contributing guide

Research direction

Start with Migration\Handler\Settings\UrlSuffix::handle, which the issue identifies as adding the dot during migration. Reproduce the migration with catalog/seo/product_url_suffix set to /, then verify that the migrated value remains / and does not create incorrect url_rewrite entries when a product is added.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.