magento / magento/data-migration-tool
Data Type comparison - might be more advanced
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 339
- Forks
- 195
- PR merge metrics
- No merged PRs in 30d
Description
A lot of fields throw me an warning with message:
Mismatch of data types ... but in my opinion they shouldn't .
Example? sales_flat_invoice.order_currency_code is char(3) field, and in magento 2 sales_invoice.order_currency_code is varchar(3).
I can try to make you new pull request for it if you agree - and if I will find time for that.. The change ought to be done here: \Migration\App\Step\AbstractIntegrity::verifyFields
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read Migration\App\Step\AbstractIntegrity::verifyFields first, focusing on how it compares source and destination field types. Use the sales_flat_invoice.order_currency_code and sales_invoice.order_currency_code example to understand the reported warning. Done means the intended comparison behavior for compatible types is agreed and verified for this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100