magento / magento/community-features

feature request: make _calcHeight and _isOverflowed of minicart sidebar.js optional

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

moved from magento2 Priority: P4
Dominant language
No language data
Stars
46
Forks
14
PR merge metrics
No merged PRs in 30d

Description

### Preconditions

1. add more than 6 items to the cart
2. open the minicart
3. all current Magento versions (2.2.4+, 2.3, 2.1.x)

### Steps to reproduce

1. open the minicart
2. the
3.

### Expected result

1. an option to disable both methods to prevent the calculated height / scroll

### Actual result

1. I can not disable these options without overwriting sidebar.js

I think it also makes sense to optionally support some maxHeight value instead of maxItems value as some items have many lines of text in the name in some shops (long product names which include product attributes) so 65 items for example could also take much height. When we make both optionally we can use CSS values however we want to.

**Original Report**: https://github.com/magento/magento2/issues/17433 by @DanielRuf

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the minicart sidebar.js implementation and inspect how _calcHeight and _isOverflowed are used. Define completion as providing options to disable both behaviors and optionally use a maxHeight value instead of maxItems; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.